feat: refactor code_owner code from edx-dajango-utils #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robrap
commented
Oct 23, 2024
robrap
commented
Oct 23, 2024
robrap
force-pushed
the
robrap/add-code-owner-monitoring
branch
from
ce0a75e
to
1d3af1c
Compare
|
Note to Reviewer: I did initial local testing to POC the celery span resource name was available locally, but I did not do a final local test. I wasn't able to get to a real celery task locally. |
timmc-edx
reviewed
Oct 28, 2024
timmc-edx
reviewed
Oct 28, 2024
...experiments/datadog_monitoring/docs/how_tos/update_monitoring_for_squad_or_theme_changes.rst
Outdated
Show resolved
Hide resolved
timmc-edx
reviewed
Oct 29, 2024
timmc-edx
reviewed
Oct 29, 2024
...experiments/datadog_monitoring/docs/how_tos/update_monitoring_for_squad_or_theme_changes.rst
Outdated
Show resolved
Hide resolved
timmc-edx
reviewed
Oct 29, 2024
robrap
commented
Nov 13, 2024
There was a problem hiding this comment.
@timmc-edx: Thanks. This is ready for re-review. It needs to be rebased, but that requires re-running make upgrade, and I still don't know how to do that cleanly. It would be great to have a way to do so.
...experiments/datadog_monitoring/docs/how_tos/update_monitoring_for_squad_or_theme_changes.rst
Outdated
Show resolved
Hide resolved
...experiments/datadog_monitoring/docs/how_tos/update_monitoring_for_squad_or_theme_changes.rst
Outdated
Show resolved
Hide resolved
This is the code_owner code as found in edx-django-utils.
Initial rollout of moving code_owner monitoring code from edx-django-utils to this plugin. - Adds near duplicate of code owner middleware from edx-django-utils. - Adds code owner for celery using Datadog span processing of celery.run spans. - Uses temporary span tags names using `_2`, like `code_owner_2`, for rollout and comparison with the original span tags. See #784
1. switch get_code_owner_from_module => set_code_owner_attribute_from_module. 2. Update tests with deeper mock of set_custom_attribute. 3. Remove decorator set_code_owner_attribute and associated tests. 4. Fix minor rst issues.
robrap
force-pushed
the
robrap/add-code-owner-monitoring
branch
from
8137b68
to
433efbf
Compare
timmc-edx
approved these changes
Nov 14, 2024
2 tasks
timmc-edx
reviewed
Nov 21, 2024
timmc-edx
reviewed
Nov 21, 2024
|
(None of those are blocking comments.) |
Co-authored-by: Tim McCormack <[email protected]>
Co-authored-by: Tim McCormack <[email protected]>
Co-authored-by: Tim McCormack <[email protected]>
robrap
commented
Nov 21, 2024
timmc-edx
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to Reviewer: The original edx-django-utils code was copied in as a separate commit to make it easier to see what was added and what was updated if you review commit by commit.
Initial rollout of moving code_owner monitoring code from edx-django-utils to this plugin.
_2, likecode_owner_2, for rollout and comparison with the original span tags.See #784
Merge checklist:
Check off if complete or not applicable: